Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle auto-advance not working / confusing documentation #1268

Closed
3 of 9 tasks
PatrickF1 opened this issue Dec 23, 2021 · 5 comments
Closed
3 of 9 tasks

Toggle auto-advance not working / confusing documentation #1268

PatrickF1 opened this issue Dec 23, 2021 · 5 comments
Labels

Comments

@PatrickF1
Copy link
Contributor

PatrickF1 commented Dec 23, 2021

Environment details (Put x in the checkbox along with the information)

  • Operating System: macOS 12.0.1
  • Desktop Environment:
  • Terminal Emulator: iTerm2
  • Shell: tested on bash, zsh, and fish
  • Custom desktop opener (if applicable):
  • Program options used:
  • Configuration options set: -n
  • Plugins are installed: fzcd
  • Issue exists on nnn master

Exact steps to reproduce the issue

Problem 1: + doesn't seem to change the behavior of type-to-nav

  1. Execute nnn -n
  2. Type to confirm directories auto-opened once unique match found
  3. Escape and hit +
  4. Directories are still auto-opening once unique match found

Based on #1209, I was expecting + to stop directories from auto-opening once unique match found.

Problem 2: no clarification on the meaning of auto-advance, auto-proceed, and auto-select.
These terms can all be found by grepping auto- in the manpage. They all sound very similar and yet they are mentioned without any explanation of what they do or how they are different. I also checked the readme, GitHub issues and the GitHub Wiki and still couldn't find anything. I would suggest adding some clarification in the manpages. e.g. for -J I'd rewrite it to automatically advance cursor after making a selection
Btw, having problem 1 still leaves me confused about the difference between auto-select and auto-proceed. Could you explain the difference please?

@PatrickF1 PatrickF1 added the bug label Dec 23, 2021
@N-R-K
Copy link
Collaborator

N-R-K commented Dec 23, 2021

Directories are still auto-opening once unique match found

You can use the -A flag to disable auto opening in type-to-nav mode.

for -J I'd rewrite it to automatically advance cursor after making a selection

That's a good suggestion, would be an improvement over the current description.

Btw, having problem 1 still leaves me confused about the difference between auto-select and auto-proceed. Could you explain the difference please?

auto-proceed seems to be the -J flag, which simply moves the cursor to next entry after making a selection. I don't remember what auto-select and auto-advance are off the top of my head.

@N-R-K N-R-K added question and removed bug labels Dec 23, 2021
@PatrickF1
Copy link
Contributor Author

Thanks @N-R-K! So what is + supposed to do then?

N-R-K added a commit to N-R-K/nnn that referenced this issue Dec 23, 2021
some of the terms used in the manpage aren't exactly obvious, especially
to a new user. this is an attempt at making the manual more clear and
remove any potential confusion.

here's a couple issues i've noticed where users were confused due to non
clear manpage description:

jarun#1268
jarun#1269
jarun#1209
@jarun
Copy link
Owner

jarun commented Dec 25, 2021

@PatrickF1 + auto-advances to the next file when you open a file.

The auto-advance and auto-proceed terms mean the same and are based on the context. -J disables auto-proceed on selection, + enables auto-proceed on opening a file.

Auto-select is for directories in type-to-nav mode. Maybe auto-enter is a better term.

N-R-K added a commit to N-R-K/nnn that referenced this issue Dec 25, 2021
some of the terms used in the manpage aren't exactly obvious, especially
to a new user. this is an attempt at making the manual more clear and
remove any potential confusion.

here's a couple issues i've noticed where users were confused due to non
clear manpage description:

jarun#1268
jarun#1269
jarun#1209
@jarun
Copy link
Owner

jarun commented Dec 25, 2021

Documentation fixed in PR #1270.

@jarun jarun closed this as completed Dec 25, 2021
@PatrickF1
Copy link
Contributor Author

@PatrickF1 + auto-advances to the next file when you open a file.

Ohhh gotcha. Interesting! Glad we fixed the docs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants