Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preview-tui]: some pager pid error #1583

Closed
4 of 9 tasks
kuntau opened this issue Feb 15, 2023 · 5 comments · Fixed by #1593
Closed
4 of 9 tasks

[preview-tui]: some pager pid error #1583

kuntau opened this issue Feb 15, 2023 · 5 comments · Fixed by #1593
Labels

Comments

@kuntau
Copy link
Contributor

kuntau commented Feb 15, 2023

Environment details (Put x in the checkbox along with the information)

  • Operating System: MacOS
  • Desktop Environment:
  • Terminal Emulator: Wezterm
  • Shell: zsh
  • Custom desktop opener (if applicable):
  • Program options used:
  • Configuration options set:
  • Plugins are installed
  • Issue exists on nnn master

Exact steps to reproduce the issue

I always got this error but not sure what the root cause.

preview-tui: line 305: 81359 Terminated: 15          $NNN_PAGER < "$FIFOPATH"

I guess it's had something to do with pid that was killed and this error should be redirected to /dev/null

The previewer works fine except those error appear on top of preview window

@kuntau kuntau added the bug label Feb 15, 2023
@luukvbaal
Copy link
Collaborator

Haven't been able to reproduce this, I did notice another issue with wezterm that should be fixed by #1585.

Could you elaborate how/when you see the error?

@kuntau
Copy link
Contributor Author

kuntau commented Feb 17, 2023

Screenshot 2023-02-16 at 2 34 00 AM

Could you elaborate how/when you see the error?

Nothing special. Just open preview-tui and browser around. What I've noticed the error didn't appear when the pager is bat or images

@kuntau
Copy link
Contributor Author

kuntau commented Feb 17, 2023

nnn.mov

@luukvbaal
Copy link
Collaborator

Not sure what could cause this. I do wonder why the error states line 305.... Are you using the latest preview-tui? Line 305 is a function definition on master.

@kuntau
Copy link
Contributor Author

kuntau commented Feb 19, 2023

Not sure what could cause this. I do wonder why the error states line 305.... Are you using the latest preview-tui? Line 305 is a function definition on master.

Yes, latest preview-tui. Anyway, I've found the offending line. Can you verify @luukvbaal ?

luukvbaal added a commit to luukvbaal/nnn that referenced this issue Feb 19, 2023
luukvbaal added a commit to luukvbaal/nnn that referenced this issue Feb 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants