Icons using emoji #1356
Icons using emoji #1356
Conversation
|
The cell width issue should be fixed by 936d6fb, but still not entirely sure if mixing single and double width emojies are a good idea or not. Looks ugly IMO.
|
|
Looks clean to me. Let's hear about the width from the users. ;) |
|
Thank you so much! |
|
The game and code emoji are not showing correctly on xubuntu 22.04, xfce4-terminal. Can you please have a look? |
|
@dkabus At commit af94c77 I removed all the additional emojis you added. I think I made it very clear in the defect that I wanted something minimal, not with additional bells and whistles. This is a public project, we do not want non-standard stuff. If you need those for your custom distro, please patch downstream. |
| @@ -269,14 +280,19 @@ upload-local: sign static musl | |||
| curl -XPOST 'https://uploads.github.com/repos/jarun/nnn/releases/$(ID)/assets?name=$(BIN)-nerd-static-$(VERSION).x86_64.tar.gz' \ | |||
| -H 'Authorization: token $(NNN_SIG_UPLOAD_TOKEN)' -H 'Content-Type: application/x-sharedlib' \ | |||
| --upload-file $(BIN)-nerd-static-$(VERSION).x86_64.tar.gz | |||
| # upload emoji compiled static binary | |||
| tar -zcf $(BIN)-emoji-static-$(VERSION).x86_64.tar.gz $(BIN)-icons-static | |||
There was a problem hiding this comment.
@jarun Just noticed this while trying to test the released emoji static binary. It tar-ed the icons-in-terminal binary instead of the emoji binary.
I have implemented icons using emoji such that it works in my version of the suckless terminal st. This addresses the feature request #1346.