When handling bookmark, use readlink, not realpath #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-R-K
requested changes
Nov 22, 2023
7ocb
force-pushed
the
handle-link-by-readlink-not-realpath-mk2
branch
from
fd98436
to
e5a2587
Compare
KlzXS
requested changes
Nov 22, 2023
7ocb
force-pushed
the
handle-link-by-readlink-not-realpath-mk2
branch
from
e5a2587
to
6628fb0
Compare
N-R-K
reviewed
Nov 22, 2023
This is to cd to path as it pointed by symlink, not to it's real path. Bookmarked directory may itself contain symlinks in path, which should be respected. For example: if directory is physically in /mnt/storage/some and it's symlinked to ~/some and directory ~/some/dir added to bookmarks, it's expected that when following bookmark directory will be changed to ~/some/dir (as in bookmark's link) not to /mnt/storage/some/dir (as dir real path).
7ocb
force-pushed
the
handle-link-by-readlink-not-realpath-mk2
branch
from
6628fb0
to
9aaf949
Compare
N-R-K
approved these changes
Nov 22, 2023
|
Thanks guys! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to cd to path as it pointed by symlink, not to it's real path. Bookmarked directory may itself contain symlinks in path, which should be respected.
For example: if directory is physically in
/mnt/storage/someand it's symlinked to~/someand directory~/some/diradded to bookmarks, it's reasonable to expect that when following bookmark directory will be changed to~/some/dir(as in bookmark's link) not to/mnt/storage/some/dir(as dir real path).It's reasonable to expect this behavior because this follows the
cdbehavior (both shellcdandnnnchanging directory) when changing directory into symlink.Also, with behavior as in this PR user can have both bookmarks to "short" path (i.e.
~/some/dirin example above) and long path (i.e./mnt/storage/some/dir) - which path is actually bookmarked, that path will be followed. Original behavior disallows using bookmarks to go to "short" path.