show linenumber when in SEL_JUMP #1804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you test this will very long filenames? Also, what is the keybind to show the relative numbers? |
jarun
requested changes
Feb 2, 2024
| @@ -306,6 +306,7 @@ typedef struct entry { | |||
| uid_t uid; /* 4 bytes */ | |||
| gid_t gid; /* 4 bytes */ | |||
| #endif | |||
| int ncount; | |||
There was a problem hiding this comment.
This increases memory usage per file. Why do we need to store this and not calculate on the fly?
There was a problem hiding this comment.
Simpler approach in #1808 which doesn't require storing counts.
N-R-K
added a commit
to N-R-K/nnn
that referenced
this pull request
Feb 3, 2024
Co-authored-by: Darukutsu <darupeter@pm.me> Closes: jarun#1804 Closes: jarun#1708
N-R-K
added a commit
to N-R-K/nnn
that referenced
this pull request
Feb 3, 2024
Co-authored-by: Darukutsu <darupeter@pm.me> Closes: jarun#1804 Closes: jarun#1708
N-R-K
added a commit
to N-R-K/nnn
that referenced
this pull request
Feb 3, 2024
Co-authored-by: Darukutsu <darupeter@pm.me> Closes: jarun#1804 Closes: jarun#1708
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion.
I reworked my previous answer a bit. I think this should be part of nnn, since it's (IMO) hard to manually count down. Or at least include as native patch.
We could also show relative/absolute linenumber always(with minor tweaks), but that doesn't seem to be useful in any way yet.