Fix file creation on OpenBSD #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-R-K
approved these changes
Apr 4, 2024
|
@horrad Please put what you wrote in the PR description in the commit message body as well. |
On OpenBSD at least one of O_RDONLY, O_WRONLY or O_RDWR is needed to open a file.
In creating a new file none of those is set, which leads to an EINVAL error ("invalid argument").
Since the new file is only created and never read, I chose to use O_WRONLY.
|
|
Can you please make the patch BSD-specific? |
|
I think it's best we avoid adding unnecessary
We have none of those. |
|
Makes sense. Merged. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OpenBSD at least one of O_RDONLY, O_WRONLY or O_RDWR is needed to open a file.
In creating a new file none of those is set, which leads to an EINVAL error ("invalid argument").
Since the new file is only created and never read, I chose to use O_WRONLY.