Add cmdline and runtime options to not move to next entry after select key #713
Conversation
|
Typos fixed. |
|
We can't have a new keybind for this. If becomes unmanageable if everyone is looking for a keybind for minor behavioral aspects they don't like. We can consider having the program option and you have to stick to a choice for the session. What problem do you see with auto move on selection? Asking this because it was specifically added on a user request and I personally consider it a better user experience. |
|
I'm okay with just an option. Well, sometimes you're just moving up while selecting, or sometimes you're just carefully thinking about what all to select and it's a little jarring to the brain that you don't need a Just silly little opinionated things, like all UI/UX stuff is :P |
|
I understand. Please take care of the review comments and update the PR. |
|
@jarun Amended the first commit and dropped the second 👍 |
| @@ -18,6 +18,7 @@ | |||
| .Op Ar -F | |||
| .Op Ar -g | |||
| .Op Ar -H | |||
| .Op Ar -j | |||
There was a problem hiding this comment.
Please make this capital J. So far I am using the capital to disable things.
| @@ -7248,6 +7249,7 @@ static void usage(void) | |||
| " -F show fortune\n" | |||
| " -g regex filters [default: string]\n" | |||
| " -H show hidden files\n" | |||
| " -j disable auto-proceed on select" | |||
There was a problem hiding this comment.
no auto-proceed on select
saves a few bytes.
|
Thank you! I'll make the rest of the changes. |
|
Thanks! Really love all the work put into this project! |
|
Me too! ;) |
| @@ -314,6 +314,7 @@ typedef struct { | |||
| uint selmode : 1; /* Set when selecting files */ | |||
| uint oldcolor : 1; /* Show dirs in context colors */ | |||
| uint reserved : 14; | |||
There was a problem hiding this comment.
@FriendlyNeighborhoodShane we should have made the reserved field 13 bits in width. We both missed this.
There was a problem hiding this comment.
Whoops. haha. Thanks for informing me about this, didn't even realise that was futureproof padding at the end of the struct.
I'm no C veteran, but I think both experienced and new hackers would benefit from a comment explicitly stating its purpose there.
I just found it more intuitive to work with, understandable if you don't want to support this workflow in upstream. Also the keybinds maybe could be better, I feel, I wanted to have the same lowercase char for both cmdline and runtime but
git grep -o "'.'" src/nnn.* | sed 's|.*:||g' | sort -usays none are left for grabs.