Fix frozen terminal caused by opener #858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xdg-open
would launch a cli program that would contest the terminal for character input resulting in a unresponsive terminal that's hard to use. There are many references to this issue, but I'm bad at finding them.If you send
xdg-opens
'sstd{in,out,err}
to the shadow realm it seems to prevent it from launching cli programs (probably because they don't want to work without any I/O, but I guess you can may be able to find some oddballs) so it defaults to some gui program (probably firefox) and that doesn't block the terminal.This should be tested to make sure the other openers are okay with silencing their
std{in,out,err}
.