Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue with sub windows - modal not working #108
Above code will not open any window. When you remove
There's an issue in the above code, in that it doesn't call
However, I see two things to investigate here:
I'll keep this issue open as an investigation into modal, and will raise a new issue to consider how to best implement a sequence of windows being used, and how to specify showing a subWindow first, rather than the main app...
The work around was to take the modal out and to place a transparency on the main window until the user logged in. When that was successful i then hid the subwindow and changed the transparency back to the main window.
Ill post the code tomorrow morning when I'm back at work.
Next_release will have
So, the final three lines of code above can be replaced with:
And, instead of increasing transparency to show the main window, you simply call:
@jacobthetechy I've looked into this some more.
Setting the popup as
This explains the issues you had with your original code.
The changes mentioned above also break when
The changes above also don't cater for having the main window launch, with a dialog drawn above it - which may have been your original use case?
Modal dialogs have a few few function calls available:
If the user is declaring a modal window, they definitely want 1 & 3.
2 & 4 are not necessarily characteristics of modal windows, they should be configurable separately:
added a commit
Apr 12, 2017
Final thing to look into is grouping - it's being configured in the SubWindow, and there is a parameter for it, but it's not documented.
Also can update testing now, to include some modal windows...