Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smarter background handling #14

Open
neinseg opened this issue Mar 19, 2021 · 0 comments
Open

Add smarter background handling #14

neinseg opened this issue Mar 19, 2021 · 0 comments

Comments

@neinseg
Copy link
Collaborator

neinseg commented Mar 19, 2021

Currently, when converting an SVG file with black background and white foreground using --format gerber will produce clear gerber primitives on top of clear background in the output. We should figure out a way to handle this properly in all cases.

Simply pasting a rect of the same color as the background behind everything will not work properly since that may actually change the bounding box of the design. Possibly the best way to deal with this might be to add some logic to catch this case that will advertise the --flip-gerber-polarity flag.

See #13.

@neinseg neinseg changed the title Add proper background handling Add smarter background handling Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant