Merge pull request #1008 from braddunbar/missing-callback

`on` is a noop if no callback is provided
jashkenas · Feb 14, 2012 · 04e2e20 · 04e2e20
2 parents b9e36f0 + 8b285c6
commit 04e2e20
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/backbone.js b/backbone.js
@@ -86,6 +86,7 @@
     // function. Passing `"all"` will bind the callback to all events fired.
     on: function(events, callback, context) {
       var ev;
+      if (!callback) return this;
       events = events.split(/\s+/);
       var calls = this._callbacks || (this._callbacks = {});
       while (ev = events.shift()) {

diff --git a/test/events.js b/test/events.js
@@ -145,4 +145,8 @@ $(document).ready(function() {
     equal(counter, 2, 'unbind does not alter callback list');
   });
 
+  test("if no callback is provided, `on` is a noop", function() {
+    _.extend({}, Backbone.Events).bind('test').trigger('test');
+  });
+
 });