Merge pull request #4284 from olhapi/master with added test

jashkenas · Jan 23, 2024 · 0f9956b · 0f9956b
2 parents e6d434e + d981caa
commit 0f9956b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/backbone.js b/backbone.js
@@ -1085,7 +1085,7 @@
       var success = options.success;
       options.success = function(m, resp, callbackOpts) {
         if (wait) {
-          m.off('error', this._forwardPristineError, this);
+          m.off('error', collection._forwardPristineError, collection);
           collection.add(m, callbackOpts);
         }
         if (success) success.call(callbackOpts.context, m, resp, callbackOpts);

diff --git a/test/collection.js b/test/collection.js
@@ -674,6 +674,16 @@
     this.ajaxSettings.success();
   });
 
+  QUnit.test('successful create with wait:true drops special error listener (#4284)', function(assert) {
+    assert.expect(1);
+    var collection = new Backbone.Collection;
+    collection.url = '/test';
+    collection.on('error', function() { assert.ok(true); });
+    var model = collection.create({id: '1'}, {wait: true});
+    this.ajaxSettings.success();
+    model.trigger('error');
+  });
+
   QUnit.test('failing create pre-existing with wait:true triggers once (#4262)', function(assert) {
     assert.expect(1);
     var model = new Backbone.Model;