Skip to content

Commit

Permalink
Backbone 0.9.9
Browse files Browse the repository at this point in the history
  • Loading branch information
jashkenas committed Dec 13, 2012
1 parent 87a25d5 commit 18b445e
Show file tree
Hide file tree
Showing 8 changed files with 912 additions and 653 deletions.
72 changes: 37 additions & 35 deletions backbone-min.js

Large diffs are not rendered by default.

10 changes: 2 additions & 8 deletions backbone.js
@@ -1,4 +1,4 @@
// Backbone.js 0.9.9-pre // Backbone.js 0.9.9


// (c) 2010-2012 Jeremy Ashkenas, DocumentCloud Inc. // (c) 2010-2012 Jeremy Ashkenas, DocumentCloud Inc.
// Backbone may be freely distributed under the MIT license. // Backbone may be freely distributed under the MIT license.
Expand Down Expand Up @@ -34,7 +34,7 @@
} }


// Current version of the library. Keep in sync with `package.json`. // Current version of the library. Keep in sync with `package.json`.
Backbone.VERSION = '0.9.9-pre'; Backbone.VERSION = '0.9.9';


// Require Underscore, if we're on the server, and it's not already present. // Require Underscore, if we're on the server, and it's not already present.
var _ = root._; var _ = root._;
Expand Down Expand Up @@ -566,12 +566,6 @@
return _.clone(this._previousAttributes); return _.clone(this._previousAttributes);
}, },


// Check if the model is currently in a valid state. It's only possible to
// get into an *invalid* state if you're using silent changes.
isValid: function(options) {
return !this.validate || !this.validate(this.attributes, options);
},

// Run validation against the next complete set of model attributes, // Run validation against the next complete set of model attributes,
// returning `true` if all is well. If a specific `error` callback has // returning `true` if all is well. If a specific `error` callback has
// been passed, call that instead of firing the general `"error"` event. // been passed, call that instead of firing the general `"error"` event.
Expand Down
96 changes: 69 additions & 27 deletions docs/backbone-localstorage.html

Large diffs are not rendered by default.

973 changes: 519 additions & 454 deletions docs/backbone.html

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion docs/docco.css
Expand Up @@ -21,6 +21,12 @@ h1, h2, h3, h4, h5, h6 {
h1 { h1 {
margin-top: 40px; margin-top: 40px;
} }
hr {
border: 0 none;
border-top: 1px solid #e5e5ee;
height: 1px;
margin: 20px 0;
}
#container { #container {
position: relative; position: relative;
} }
Expand Down Expand Up @@ -115,7 +121,7 @@ table td {
} }
pre, tt, code { pre, tt, code {
font-size: 12px; line-height: 18px; font-size: 12px; line-height: 18px;
font-family: Monaco, Consolas, "Lucida Console", monospace; font-family: Menlo, Monaco, Consolas, "Lucida Console", monospace;
margin: 0; padding: 0; margin: 0; padding: 0;
} }


Expand Down
71 changes: 36 additions & 35 deletions docs/todos.html

Large diffs are not rendered by default.

333 changes: 241 additions & 92 deletions index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -14,5 +14,5 @@
"test": "phantomjs test/vendor/runner.js test/index.html" "test": "phantomjs test/vendor/runner.js test/index.html"
}, },
"main" : "backbone.js", "main" : "backbone.js",
"version" : "0.9.9-pre" "version" : "0.9.9"

This comment has been minimized.

Copy link
@jed

jed Dec 14, 2012

Contributor

i think this should really be 0.10.0, given that there are breaking changes. would love to see better semver hygiene from backbone in the future.

This comment has been minimized.

Copy link
@jashkenas

jashkenas Dec 14, 2012

Author Owner

I'm afraid that technically speaking, the semantic versioning is still correct. Quoth http://semver.org:

Patch version Z (x.y.Z | x > 0) MUST be incremented if only backwards compatible bug fixes are
introduced. A bug fix is defined as an internal change that fixes incorrect behavior.

... the rules only apply if the codebase is greater than 1.0. In fact, if you read further:

Major version X (X.y.z | X > 0) MUST be incremented if any backwards incompatible changes
are introduced to the public API. It MAY include minor and patch level changes. Patch and
minor version MUST be reset to 0 when major version is incremented.

That said, I also find semantic versioning a pretty hard idea to get behind. Any change worthy of the name breaks backward compatibility in some small way -- even if just for a single edge case, for a single user. I'd be hard pressed to remember a Backbone version bump that didn't change behavior or add features in one minor way or another. So if we followed the spirit of the law of semver.org, Backbone would be at version 16.0. I'd rather use the version number to convey the relative magnitude of the change -- and the "Upgrading" section of the docs to convey the specific things you'll want to know in order to upgrade.

} }

0 comments on commit 18b445e

Please sign in to comment.