New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added optional groups to route syntax, with tests #1509
Conversation
I'd love this to be merged, @documentcloud can we get this in? |
Very nice. Can we use Rails' parentheses syntax instead of brackets for the optional parts? Make that change, and maybe add the little bit of docs about this to index.html, and I'll be glad to merge. |
makes sense, i'll make that change very soon. thanks! |
okay, switched to parentheses. added a section to the docs, and also broke up the route examples into the docs into separate paragraphs since it was getting very complicated to follow along after adding the third example. |
Mind rebasing against master so there's a clean merge? |
sure thing, all rebased and updated test names to match. |
Thanks a bunch -- beautiful patch. |
added optional groups to route syntax, with tests
Fantastic. This also allows optional trailing slashes, which I think will make a good many people happy. routes: {
"route(/)": "route"
} |
this is phenomenal. thanks, @ianstormtaylor |
@ianstormtaylor yeah boi! |
from the ideas in #1508