Call 'beforeSend' function set with $.ajaxSetup when Backbone.emulateHTT... #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HTTP is set to true.
Previously if we set:
Backbone.emulateHTTP = true;
and 'beforeSend' on $.ajax via:
$.ajaxSetup({
beforeSend: function (xhr) {
xhr.setRequestHeader('X-CSRFToken', $.cookie('csrftoken'));
}
});
Then 'beforeSend' won't be called on xhr requests.
| params.beforeSend = function(xhr) { | ||
| var beforeSend = Backbone.$.ajaxSettings.beforeSend; | ||
| params.beforeSend = function(xhr, settings) { | ||
| beforeSend && beforeSend(xhr, settings); |
There was a problem hiding this comment.
beforeSend && beforeSend.apply(xhr, arguments) might be more future proof...or not worth it...just a thought. That and xhr is the correct context for beforeSend (just checked).
|
@braddunbar What if I don't pass Also documentation of jQuery says: "Returning false in the beforeSend function will cancel the request". Maybe it's worth to return value of call to the preserved 'beforeSend'? |
Addressed at #1758 |
mlowicki
pushed a commit
to mlowicki/backbone
that referenced
this pull request
Oct 19, 2012
|
Issue with not calling global beforeSend addressed at #1759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...P is set to true.
Previously if we set:
and 'beforeSend' on $.ajax via:
Then 'beforeSend' won't be called on xhr requests.