Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more minor typo fixes to docs #2412

Merged
merged 3 commits into from Mar 21, 2013
Merged

Conversation

philfreo
Copy link
Contributor

No description provided.

tgriesser added a commit that referenced this pull request Mar 21, 2013
@tgriesser tgriesser merged commit 3a94f4e into jashkenas:master Mar 21, 2013
@tgriesser
Copy link
Collaborator

Thanks

@jashkenas
Copy link
Owner

Revert the "lowercasing", please. They're uppercase for a reason -- see the previous discussions.

@philfreo
Copy link
Contributor Author

My bad -- I thought I recalled the discussion going the other way. Guess not.

@tgriesser
Copy link
Collaborator

Yeah, per #2219 (while you were away)... we can change them all back, didn't realize the reasons.

@philfreo
Copy link
Contributor Author

Ah yes - I knew I saw it somewhere :)

Seems like the "instances are lowercased" convention is stronger and more important in JavaScript than trying to indicate global scope (window. typically used for that)

@tgriesser
Copy link
Collaborator

@jashkenas I guess the previous discussion you're referring to was #1395?

@tgriesser
Copy link
Collaborator

Also, I agree with @philfreo, in practice you shouldn't be putting things in the global scope (and there is no concept of scoping in docs), so I believe most just find it confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants