Fix for ignored {parse: false} on save

[tgriesser]

If {parse: false} is passed in the options during a save, the model should not attempt to parse the response after the save completes.

[braddunbar]

Hey Tim! #2456 is very similar regarding Model#fetch, not sure if you saw it, and I have the same question here I guess. Why would you want to skip parsing server data?

[tgriesser]

Because on the initial model fetch, there are bunch of associated models/collections that i've stripped off in parse and placed directly on the model, so I don't really want to run that parse again. After the save it's only returning back the data associate with the model's attributes, excluding all related items.

[tgriesser]

It makes sense that you'd want to keep the server stuff parsed... I'm going to come up with a different solution for handling the relations, etc.

[ediblecode]

Hi, I've just come across this. In answer to the question 'Why would you want to skip parsing server data?', I have a use-case: I'm calling save() with {parse: false} as the options because on an update (push) request, the server set-up I'm working with responds with something like {"isValid":true,"errors":[],"data":null} and not the model data. I can't change the server set-up and obviously don't want these properties set on my model so not parsing the response is pretty useful.

[jashkenas]

That's a great use case for parsing. Use a parse function to filter out those (expected, but invalid) properties from the response.

[ediblecode]

Ah yes, great shout, thanks Jeremy.

[fantactuka]

Comments above Model#save says:

// After a successful server-side save, the client is (optionally)
// updated with the server-side state.

while there's no option to prevent server response from being merged into model.

Going back to { parse: false } in model's save, it's still possible to do

parse: function(json, options) {
  if (!options.parse) {
    return;
  }
}

but it looks strange that method should check whether it should have been called or not.

I'd say parse option should be checked before parse method is being called + there should be a way to prevent server response being merged into model's attributes (e.g. merge: false option or smth similar).