Handle incorrect hash/search values in IE6. #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In IE6, the hash/search value will not be correct when the hash fragment contains '?'.
|
|
||
| getSearch: function() { | ||
| var match = this.location.href.replace(/#.*$/, '').match(/\?.+$/); | ||
| return match ? match[0] : ''; |
There was a problem hiding this comment.
Why do we need the $ marker here?
There was a problem hiding this comment.
Good catch! I think you're right, it's probably not necessary.
There was a problem hiding this comment.
Updated in 5573ef7.
|
@braddunbar @jdalton is this good to merge? |
|
Yep yep. 👍 |
braddunbar
added a commit
that referenced
this pull request
Aug 18, 2014
Handle incorrect hash/search values in IE6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IE6, the hash/search value will not be correct when the hash
fragment contains '?'.
Thanks for pointing out the failure @jdalton!