clear should set attributes to defaults
#3395
Conversation
samjoch
force-pushed
the
clear-should-set-to-defaults
branch
2 times, most recently
from
a62f03a
to
2a17d0c
Compare
|
I think most often when you clear the model you want it cleared. You can always reset the initial state after. |
| var attrs = {}; | ||
| for (var key in this.attributes) attrs[key] = void 0; | ||
| return this.set(attrs, _.extend({}, options, {unset: true})); | ||
| var attrs = _.defaults({}, attrs, _.result(this, 'defaults')); |
There was a problem hiding this comment.
where is attrs coming from? typo?
|
Agreed with @akre54 on the semantics of |
samjoch
force-pushed
the
clear-should-set-to-defaults
branch
from
2a17d0c
to
c286928
Compare
|
Are we talking about a |
|
This functionality can be achieved pretty easily like so: To avoid a double-flash in your view, you could add a custom option to the |
|
I think simpler wins out here. Thanks anyways. |
- Adds `{ reset: true }` flag to `#set` that deletes any attributes
that are not specified
- Adds ‘reset’ event mirroring `Collection`’s.
Fixes jashkenas#3253, jashkenas#3395.
I could really use help naming the `validateCombined` option. I need to
validate only the passed in `attrs` (both `#clear` and `#reset` specify
_exactly_ what the attributes will be), not the merged `attrs`
`attributes`.
When i defined
defaultsattributes, onclearthose values are not retrieved.