Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 1.3.3 Release #3998

Merged
merged 2 commits into from Apr 5, 2016
Merged

Create 1.3.3 Release #3998

merged 2 commits into from Apr 5, 2016

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Mar 28, 2016

Fixes #3993; Closes #3994

/cc @jridgewell create a git tag and npm release when merged

@jridgewell
Copy link
Collaborator

Getting some errors.

@megawac
Copy link
Collaborator Author

megawac commented Mar 28, 2016

Thats not related to this PR though should be looked into
https://travis-ci.org/jashkenas/backbone/builds

On Mon, Mar 28, 2016 at 4:55 PM, Justin Ridgewell notifications@github.com
wrote:

Getting some errors.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#3998 (comment)

@akre54
Copy link
Collaborator

akre54 commented Mar 29, 2016

Looks like the first failure was https://travis-ci.org/jashkenas/backbone/builds/90800675

UPDATE: Most seem to be in not cleaning up globals (test-element, onhashchange, etc), but then also 3 IE8 failures (using Array.prototype.indexOf instead of _.indexOf and 2 defaults / prototype collections bugs).

UPDATE 2: #4000 (woo! 🎉)

@megawac
Copy link
Collaborator Author

megawac commented Apr 5, 2016

Yo Justin, whats the hold up here? Travis failing here is irrelevant to the changes in this patch

@jridgewell jridgewell merged commit 8ec8860 into master Apr 5, 2016
@megawac megawac deleted the 1.3.3 branch April 5, 2016 17:53
@akre54
Copy link
Collaborator

akre54 commented Apr 5, 2016

Still need to merge over to gh-pages, update index.html, etc.

@akre54
Copy link
Collaborator

akre54 commented Apr 5, 2016

Should we npm deprecate 1.3.0 through 1.3.2 now?

@jridgewell
Copy link
Collaborator

@akre54: Can you do the gh-pages stuff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants