Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Model.urlRoot to be a function #809

Merged
merged 3 commits into from Dec 26, 2011
Merged

Conversation

rymohr
Copy link
Contributor

@rymohr rymohr commented Dec 23, 2011

This allows the root to be determined at runtime and makes it easy to support nested resources.

It's a simpler alternative to pull request #781

@jashkenas
Copy link
Owner

Interesting idea. Want to take a different stab at this pull request that uses the getValue function that's currently available on master?

@rymohr
Copy link
Contributor Author

rymohr commented Dec 23, 2011

Will do...

@paulyoder
Copy link

+1 added unit tests pass

jashkenas added a commit that referenced this pull request Dec 26, 2011
Allow Model.urlRoot to be a function
@jashkenas jashkenas merged commit 061fd3b into jashkenas:master Dec 26, 2011
@jashkenas
Copy link
Owner

Thanks folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants