Optimize _.isEqual DataView comparison (#2875)

jashkenas · Sep 21, 2020 · 00d64f4 · 00d64f4
1 parent 3e7cb29
commit 00d64f4
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 11 deletions.
diff --git a/modules/isEqual.js b/modules/isEqual.js
@@ -57,9 +57,8 @@ function deepEq(a, b, aStack, bStack) {
       return deepEq(toDataView(a), toDataView(b), aStack, bStack);
     case '[object DataView]':
       var byteLength = getByteLength(a);
-      if (byteLength !== getByteLength(b)) {
-        return false;
-      }
+      if (byteLength !== getByteLength(b)) return false;
+      if (a.buffer === b.buffer && a.byteOffset === b.byteOffset) return true;
       while (byteLength--) {
         if (a.getUint8(byteLength) !== b.getUint8(byteLength)) {
           return false;

diff --git a/underscore-esm.js b/underscore-esm.js
diff --git a/underscore-esm.js.map b/underscore-esm.js.map
diff --git a/underscore.js b/underscore.js
diff --git a/underscore.js.map b/underscore.js.map