-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"bindAll must be passed function names " #992
Labels
Comments
It's probably misleading to name it "bindAll" then, no? |
Will you please at least respect some backward compatibility? Quoting http://semver.org/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Previously to v1.4.4, using "_.bindAll(this);" would work as expected, and as per documentation: " If no methodNames are provided, all of the object's function properties will be bound to it."
In v1.4.4 "_.bindAll(this);" throws an error - "bindAll must be passed function names "
In the diff for 1.4.3 and 1.4.4 (https://gist.github.com/ahomu/4700664) at lines 107 this was changed:
This isn't in the changelog, and the documentation is out-of-date
Out of interest, why was this changed? Attempting to update 1.4.4 has broken a lot of my code!
The text was updated successfully, but these errors were encountered: