Simplification of memoize given no hasher #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| var cache = memoize.cache; | ||
| var key = hasher.apply(this, arguments); | ||
| if (hasher) key = hasher.apply(this, arguments); |
There was a problem hiding this comment.
You're gonna run into issues because changing the value of key will change the value in the arguments object too.
There was a problem hiding this comment.
Good point! What a strange language "feature"!
There was a problem hiding this comment.
Forgot about that, I'll address that and add a spec
There was a problem hiding this comment.
Ya, it bit when I tried to simplify this method before, which is why I knew to look for it :P
also specs the case mentioned by @jdalton in comments (great catch!)
michaelficarra
added a commit
that referenced
this pull request
Jun 13, 2014
Simplification of memoize given no hasher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the expected case for _.memoize