Ensure underscore can be run in a Node VM #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I understand. Wouldn't you be using CommonJS (and thus |
| @@ -14,6 +14,34 @@ | |||
|
|
|||
| }); | |||
|
|
|||
| test('noConflict', function() { | |||
No, this is for the node vm module (sandboxes)
You probably would't; the bigger issue is we're not correctly detecting the global, and thus the export for the vm, |
| @@ -14,6 +14,34 @@ | |||
|
|
|||
| }); | |||
|
|
|||
| test('noConflict', function() { | |||
| var underscore = _.noConflict(); | |||
| equal(this._, void 0); | |||
There was a problem hiding this comment.
To avoid strict mode problems, test typeof _ instead.
megawac
added a commit
that referenced
this pull request
Jul 6, 2015
Ensure underscore can be run in a Node VM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered during caolan/async#804