Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogfood _.times in _.unzip #2634

Closed
wants to merge 2 commits into from
Closed

Conversation

captbaritone
Copy link
Collaborator

I've included @earforth's commit from #2632 and cleaned up the formatting.

@captbaritone captbaritone mentioned this pull request Dec 8, 2016
@jashkenas
Copy link
Owner

Performance impact?

@captbaritone
Copy link
Collaborator Author

Not sure of actual timing, but this will add an additional function call (using .call()) for each item in the collection. On the plus side it will also pre-allocate the array.

@jashkenas
Copy link
Owner

Might be worth checking — I'm pretty sure that's the reason why it's using a for loop in the first place.

@captbaritone
Copy link
Collaborator Author

I'm not personally very invested in this change. I'll close this issue. If someone else (@earforth @craigmichaelmartin, @jridgewell) want's to do the legwork of doing a perf evaluation, we can reopen.

@earforth
Copy link

If you need performance, please replace the pluck into codes , it's a function call, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants