Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined #2732

Closed
wants to merge 3 commits into from
Closed

undefined #2732

wants to merge 3 commits into from

Conversation

xlshen
Copy link

@xlshen xlshen commented Mar 14, 2018 •
edited

@coveralls
Copy link

coveralls commented Mar 14, 2018 •
edited

Coverage Status

Coverage remained the same at 97.002% when pulling fd574a4 on xlshen:master into 1bfc9f1 on jashkenas:master.

@xlshen xlshen mentioned this pull request Mar 16, 2018
Open
jgonggrijp
jgonggrijp reviewed May 7, 2020
View reviewed changes
underscore.js
@@ -73,6 +73,7 @@
};
// The 2-parameter case has been omitted only because no current consumers
// made use of it.
case void 0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unnecessary change because there is already a null check a few lines above this:

underscore/modules/index.js

Line 60 in 5d8ab5e

switch (argCount == null ? 3 : argCount) {

@jgonggrijp jgonggrijp closed this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgonggrijp jgonggrijp jgonggrijp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xlshen @coveralls @jgonggrijp