Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.10 release (WIP) #2834

Merged
merged 13 commits into from
Mar 30, 2020
Merged

Prepare 1.10 release (WIP) #2834

merged 13 commits into from
Mar 30, 2020

Conversation

jgonggrijp
Copy link
Collaborator

No description provided.

@jgonggrijp jgonggrijp marked this pull request as ready for review March 29, 2020 23:54
@jgonggrijp
Copy link
Collaborator Author

@jashkenas I performed all updates to the documentation I could think of, including some changes I didn't contribute myself. I checked the git log for all changes since 1.9.2 and I'm quite sure I completely represented them, at least in the changelog; this is reflected in the five commits above that mention a pull request number.

Other than that, I'm not 100% sure that I did what I'm supposed to do. If I failed to follow a convention somewhere, I apologize. I also performed some backward corrections (I hope); sorry if that was unwarranted. I made small commits so it is easy to see what I did and to change, reorder or omit individual changes.

On the presumption that you have a workflow where you do something like npm version --minor ; npm publish, I abstained from the following steps:

  • npm run build
  • npm run doc
  • update the version number in the package.json and the package-lock.json

I'll be interested to hear what you think!

<b>ExtendScript</b> <tt>#include "underscore.js"</tt>
</li>
<li>
<b>Rollup</b> If you want to enable treeshaking and you don&rsquo;t
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for Rollup, or for any ESM treeshaking bundler? (i.e. will these instructions work for Webpack too?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I don't know. I try to avoid Webpack at all cost.

Copy link
Owner

@jashkenas jashkenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect. I'll merge it and cut a release!

@jashkenas jashkenas merged commit fa2c1f8 into master Mar 30, 2020
@jashkenas jashkenas deleted the prepare-1.10 branch March 30, 2020 16:48
@jashkenas
Copy link
Owner

Okay — v.1.10.1 is out! (I had to bump a tiny patch to fix the relative module references to include file extensions for browser compatibility).

A million thank yous to @jgonggrijp for persevering with this set of changes. Like I said at the beginning — it’s rare to find someone who is actually willing to go the extra mile to make it happen. 👏👏👏

@jgonggrijp
Copy link
Collaborator Author

Hooray! It was a pleasure and I will do this kind of thing again.

Good catch about the module references, I completely forgot about <script type=module>.

So this episode is over but I am still a collaborator. In what other ways (if any) would you like me to use the push access? Is it just for the next time I make a large-ish contribution, or would you also appreciate it if, for example, I close an obsolete issue when I find one (such as #1992)? Or maybe even merge a pull request if I'm very sure it is correct?

Also, do you still use Gitter?

@jgonggrijp
Copy link
Collaborator Author

Oh by the way, you still have to push the 1.10.1 tag. :-)

@jashkenas
Copy link
Owner

Oh by the way, you still have to push the 1.10.1 tag. :-)

Thanks! Pushed.

Also, do you still use Gitter?

I'm afraid I haven't looked at that in years.

So this episode is over but I am still a collaborator. In what other ways (if any) would you like me to use the push access? Is it just for the next time I make a large-ish contribution, or would you also appreciate it if, for example, I close an obsolete issue when I find one (such as #1992)? Or maybe even merge a pull request if I'm very sure it is correct?

Use it with care and discretion — reaching the bar for collaborator access implies a level of trust that I think you’ve earned by your comportment here. If you want to close an obsolete issue or two, or merge good pull requests, or fix things, I'd very much appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants