Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for VPMUL instructions #276

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Add support for VPMUL instructions #276

merged 1 commit into from
Oct 27, 2022

Conversation

dsprenkels
Copy link
Contributor

@dsprenkels dsprenkels commented Oct 27, 2022 •
edited

This commit adds support for the (signed) (V)PMULDQ instruction under the name #VPMUL.

All support was based on the support for the (unsigned) VPMULUDQ instructions, so I conveniently based all the new code on that code.

Reviewing suggestions:

  • check if the semantics in word.v are correct;
  • check if I did not forget to add anything

Cc @vbgl
Fixes #274

@dsprenkels
Add support for VPMUL instructions
006a37d 
This commit adds support for the (signed) (V)PMULDQ instruction
under the name #VPMUL.

Fixes jasmin-lang#274
vbgl
vbgl approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Thanks!

@vbgl vbgl merged commit 46e7281 into jasmin-lang:main Oct 27, 2022
@dsprenkels dsprenkels deleted the issue-274 branch October 27, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[x86] Add support for the vpmuldq instruction
2 participants
@dsprenkels @vbgl