Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check bounds in array-expansion #331

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Check bounds in array-expansion #331

merged 1 commit into from
Jan 18, 2023

Conversation

vbgl
Copy link
Member

@vbgl vbgl commented Jan 17, 2023

cc @kcning

@vbgl vbgl added the bug label Jan 17, 2023
@vbgl vbgl marked this pull request as draft January 17, 2023 09:42
@vbgl
Copy link
Member Author

vbgl commented Jan 17, 2023

Marking as draft waiting for the corresponding issue to be opened.
CI: https://gitlab.com/jasmin-lang/jasmin/-/pipelines/749241798

@vbgl
Copy link
Member Author

vbgl commented Jan 17, 2023

Fixes #333

@vbgl vbgl marked this pull request as ready for review January 17, 2023 11:48
eponier
eponier approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@eponier eponier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearer message, indeed!

@vbgl
Copy link
Member Author

vbgl commented Jan 18, 2023

Rebased to fix merge conflicts in CHANGELOG
CI: https://gitlab.com/jasmin-lang/jasmin/-/pipelines/750427249

@vbgl vbgl merged commit 70ffb51 into main Jan 18, 2023
@vbgl vbgl deleted the array-expand-bound-check branch January 18, 2023 12:51
@vbgl vbgl mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eponier eponier eponier approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @eponier