jasminc: Add a -slice f command line argument
#414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgregoir
reviewed
Apr 19, 2023
compiler/src/slicing.ml
Outdated
| else if List.exists (String.equal n.fn_name) fs then | ||
| inspect_stmt (with_fun k n) fd.f_body | ||
| else k) | ||
| { vars = Sv.empty; funs = Sf.empty } |
There was a problem hiding this comment.
I think the code will be simpler if funs (line 50) is initialised with something like "Sf.of_list (List.map (fun fn -> (find fn in fds))".
It has two advantages, line 47 and 48 can be removed. And we can use find to produce a proper error message if the user gives a name that does not exists.
There was a problem hiding this comment.
Done. Thanks for the suggestion.
Slicing removes from a program functions and global variables that are not reachable from the selected functions. This feature has been requested in the context of safety checking: it allows to analyze a single entry-point within a larger program. Nonetheless it may be used for different purposes and in particular it makes the already available `-checkCTon` and `-ec` arguments somehow redundant.
bgregoir
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slicing removes from a program functions and global variables that are not reachable from the selected functions.
This feature has been requested in the context of safety checking: it allows to analyze a single entry-point within a larger program.
Nonetheless it may be used for different purposes and in particular it makes the already available
-checkCTonand-ecarguments somehow redundant.cc @tfaoliveira