Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86: fix semantics of VPSHUFB and VPCMPGT #449

Merged
merged 2 commits into from
May 17, 2023
Merged

x86: fix semantics of VPSHUFB and VPCMPGT #449

merged 2 commits into from
May 17, 2023

Conversation

vbgl
Copy link
Member

@vbgl vbgl commented May 16, 2023

(based on top of #446 to prevent future merge conflicts)

@vbgl vbgl changed the title x86: fix semantics of VPSHUFB x86: fix semantics of VPSHUFB and VPCMPGT May 16, 2023
@vbgl vbgl force-pushed the vpshufb branch 2 times, most recently from 2d055a2 to bc62d04 Compare May 16, 2023 15:44
Copy link
Contributor

@bgregoir bgregoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check EC sem ?

@vbgl
Copy link
Member Author

vbgl commented May 16, 2023

Yes. VPSHUFB looks OK; VPCMPGT was wrong too.

@bgregoir
Copy link
Contributor

I was stupid, it is the first file ?

@bgregoir
Copy link
Contributor

Why it is still a draft ?

@vbgl vbgl marked this pull request as ready for review May 17, 2023 07:41
@vbgl
Copy link
Member Author

vbgl commented May 17, 2023

It is ready now.

@vbgl vbgl merged commit 94cef1c into main May 17, 2023
1 check passed
@vbgl vbgl deleted the vpshufb branch May 17, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants