Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM: add instructions MLA and MLS #480

Merged
merged 1 commit into from
Jun 16, 2023
Merged

ARM: add instructions MLA and MLS #480

merged 1 commit into from
Jun 16, 2023

Conversation

vbgl
Copy link
Member

@vbgl vbgl commented Jun 16, 2023

Lowering introduce these instructions when compiling expressions of the form: x ± y * z.

@vbgl
ARM: add instructions MLA and MLS
50ba9ae 
Lowering introduce these instructions when compiling expressions of the
form: x ± y * z.
@vbgl vbgl added the arm Related to the arm port label Jun 16, 2023
bgregoir
bgregoir approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@bgregoir bgregoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arm documentation says
"r15 cannot be used for any of Rd, Rm, Rs, or Rn."
It seems to apply also to MUL. I don't think we already take this kind of constraint into account. But it seems doable.

@bgregoir
Copy link
Contributor

Since r15 is the PC, it is not so relevant...

@bgregoir bgregoir merged commit 4f949cb into main Jun 16, 2023
1 check passed
@bgregoir bgregoir deleted the arm-mla branch June 16, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgregoir bgregoir bgregoir approved these changes

Assignees
No one assigned
Labels
arm Related to the arm port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @bgregoir