Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use RSB for x = (y << n) - z; #585

Merged
merged 2 commits into from
Sep 27, 2023
Merged

use RSB for x = (y << n) - z; #585

merged 2 commits into from
Sep 27, 2023

Conversation

bgregoir
Copy link
Contributor

Should I add something in the change log?

Copy link
Member

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary (useful?) to have such a complex test case?

proofs/compiler/arm_lowering.v Outdated Show resolved Hide resolved
@vbgl
Copy link
Member

vbgl commented Sep 26, 2023

And indeed, a changelog entry would be nice.

@bgregoir
Copy link
Contributor Author

I think it is as useful x = y + z << n or x = y - z << n;
It is not needed since we can write x = #ADD(y, z << n) or x = #SUB(y, z << n); or x = RSB(z, y << n).
But it is maybe less readable.

@vbgl
Copy link
Member

vbgl commented Sep 27, 2023

I’m still not convinced by the large test case.

@bgregoir
Copy link
Contributor Author

Sorry Vincent, I miss understood your message:
" to have such a complex test case?"
I will fix that.

@bgregoir
Copy link
Contributor Author

Done, I think it is now very simple.
Again sorry for the miss understanding

@vbgl
Copy link
Member

vbgl commented Sep 27, 2023

No problem. Thanks for your contribution.

@vbgl vbgl self-assigned this Sep 27, 2023
@vbgl vbgl merged commit 0a2f1d5 into main Sep 27, 2023
1 check passed
@vbgl vbgl deleted the arm-lowering-rsb branch September 27, 2023 09:21
vbgl pushed a commit that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants