Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch as the advantage to fixes the current problem, but I think it is not the write way to do it.
I think, the best will be to introduce speudo instruction in arm:
x = #lea e
this one can be decomposed in a sequence of addition with shift.
ie x = #lea (y + z << i + c)
---->
x = #ADD(y, z << i);
x = #ADD(x, c);
x = #lea (y + c)
---->
x = #ADD(y, c); // if c is to large we can use x to compute it.
and
x = #GMOV e
this
can become either a LDR or a STR or a MOV depending of the source e and destination x.
The current patch poorly do that.