Add namespaces #734
Merged
Add namespaces #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
force-pushed
the
namespaces
branch
4 times, most recently
from
804890a
to
81dd057
Compare
bgregoir
reviewed
Feb 22, 2024
compiler/src/ppasm.ml
Outdated
| @@ -33,6 +33,7 @@ let pp_gens (fmt : Format.formatter) xs = | |||
|
|
|||
| (* -------------------------------------------------------------------- *) | |||
| let string_of_label name (p : label) = | |||
| let name = String.map (fun c -> if c = '.' || c = ':' then '_' else c) name in | |||
There was a problem hiding this comment.
It seems that we have twice the same function, maybe we should share them.
There was a problem hiding this comment.
Yes. There is already a comment about this in the code. Your contribution (as a separate PR) is welcome.
There was a problem hiding this comment.
I moved my addition to the PrintCommon module but left the duplication of string_of_label. I believe that the two asm-printers could be refactored to share their common functionality and make it easier to add new targets.
vbgl
force-pushed
the
namespaces
branch
3 times, most recently
from
5216d67
to
20a4985
Compare
bgregoir
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.