Relaxed alignment constraints for memory and array accesses #748
+1,527
−1,187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
force-pushed
the
relax-alignment
branch
2 times, most recently
from
3769910
to
8683de0
Compare
bgregoir
previously approved these changes
Mar 13, 2024
|
Let me check a few more things. |
vbgl
force-pushed
the
relax-alignment
branch
2 times, most recently
from
8bf88ed
to
8ea90a6
Compare
|
|
vbgl
changed the title
vbgl
force-pushed
the
relax-alignment
branch
3 times, most recently
from
9054d88
to
0471e14
Compare
bgregoir
force-pushed
the
relax-alignment
branch
from
c379ae7
to
e3926eb
Compare
vbgl
force-pushed
the
relax-alignment
branch
3 times, most recently
from
d2bb01d
to
a00763d
Compare
Co-authored-by: Benjamin Grēgoire <Benjamin.Gregoire@inria.fr>
eponier
previously approved these changes
Mar 28, 2024
|
Thanks Jean-Christophe for your careful review. I think I’ve addressed your concerns. |
|
The opam job was killed in the CI, similarly to #560 (comment). Do you have an idea of what happens? Maybe too much RAM used by the job? We should fix that in the long run, not for this PR of course. |
eponier
approved these changes
Mar 28, 2024
vbgl
added a commit
that referenced
this pull request
Mar 29, 2024
Co-authored-by: Benjamin Grēgoire <Benjamin.Gregoire@inria.fr> (cherry picked from commit a5293ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please contribute suggestions for concrete syntax.