Only call the completion callback once per call to execute()

jasmine · Oct 13, 2021 · 4a1178e · 4a1178e
1 parent 6b3c747
commit 4a1178e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/jasmine.js b/lib/jasmine.js
@@ -559,7 +559,11 @@ Jasmine.prototype.execute = async function(files, filterString) {
 
   await this.loadSpecs();
 
-  this.addReporter(this.completionReporter);
+  if (!this.completionReporterInstalled_) {
+    this.addReporter(this.completionReporter);
+    this.completionReporterInstalled_ = true;
+  }
+
   let overallResult;
   this.addReporter({
     jasmineDone: r => overallResult = r

diff --git a/spec/jasmine_spec.js b/spec/jasmine_spec.js
@@ -497,7 +497,7 @@ describe('Jasmine', function() {
       expect(this.testJasmine.env.configure).toHaveBeenCalledWith({specFilter: jasmine.any(Function)});
     });
 
-    it('adds an exit code reporter', async function() {
+    it('adds an exit code reporter the first time execute is called', async function() {
       const completionReporterSpy = jasmine.createSpyObj('reporter', ['onComplete']);
       this.testJasmine.completionReporter = completionReporterSpy;
       spyOn(this.testJasmine, 'addReporter');
@@ -506,6 +506,12 @@ describe('Jasmine', function() {
 
       expect(this.testJasmine.addReporter).toHaveBeenCalledWith(completionReporterSpy);
       expect(this.testJasmine.completionReporter.exitHandler).toBe(this.testJasmine.checkExit);
+      this.testJasmine.addReporter.calls.reset();
+
+      await this.testJasmine.execute();
+      expect(this.testJasmine.addReporter).not.toHaveBeenCalledWith(
+        completionReporterSpy
+      );
     });
 
     describe('when exit is called prematurely', function() {