Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

added configuration file path argument and fixed an error with invoke tasks #34

Closed
wants to merge 2 commits into from

Conversation

tylerlaberge
Copy link

@tylerlaberge tylerlaberge commented Jan 27, 2017

Following the contribution guidelines, the 'invoke install' command would cause an error until I added a 'context' positional argument to each of the tasks. The issue and fix is discussed more at pyinvoke/invoke#362.

I also added a configuration file path argument to the jasmine command in order to allow users to specify a desired path rather than being forced to use 'spec/javascripts/support/jasmine.yml' as the path. As it is now you simply can do 'jasmine --config 'some_path_to_configuration_file' and jasmine will now use that configuration file.

@tylerlaberge tylerlaberge changed the title invoke 'initial context argument' error fix added configuration file path argument and fixed an error with invoke tasks Jan 27, 2017
@sgravrock
Copy link
Member

Thanks for your contribution. We went in a different direction and removed invoke entirely (210060c and bf1a361). Invoke wasn't doing much for us, and keeping it as an un-versioned dependency would have left us open to more bugs like the one your PR was meant to fix.

@sgravrock sgravrock closed this Jun 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants