Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the HtmlReporter has a 'spec' query param, the spec list only shows matching specs/suites #1046

Merged
merged 1 commit into from
Nov 4, 2016

Conversation

d-reinhold
Copy link
Contributor

[Fixes #510]

  • This implementation does not introduce a new option/checkbox, which I find to be unnecessary/undiscoverable. If a user has filtered their specs, the Spec List should only show matches. A concern with this approach is that specs might be missing due to syntax errors. If this is the case, the user will notice the discrepancy when running the full suite with no filters. I doubt many users of jasmine commit their changes after only running a filtered set of suites (I could be wrong though).
  • This commit does not close github issue Filtering out specs in HTML report #510; it just implements a possible fix (suggested by github user 'callmevlad'). I'd like to discuss this implementation with the Jasmine maintainers before submitting a full patch with additional tests.

@slackersoft
Copy link
Member

I think we probably have enough other feedback on the page that specs are being skipped, that it should be ok to hide the specs that weren't run from the summary view as long as the symbol summary and alert sections stay the same.

@d-reinhold
Copy link
Contributor Author

@slackersoft Alert section and symbol summary sections are unaffected by this change. I've rebased this commit against jasmine/master and added a test to the HtmlReporterSpec. Let me know what you think.

@slackersoft slackersoft merged commit d1a94bc into jasmine:master Nov 4, 2016
slackersoft pushed a commit that referenced this pull request Nov 4, 2016
@voltrevo
Copy link

voltrevo commented Jun 2, 2017

@d-reinhold This kinda breaks the way I use the ui. My tests take a long time to run, so to get the spec list I frequently use ?spec=asdf so I can use it to run tests by clicking on them.

@slackersoft Would you still be receptive to a PR which would add a checkbox for this feature? Or perhaps is there another way to see the spec list I'm missing?

(While using fit/fdescribe is sometimes useful, it's not my preferred method. I don't want to wait for a new build, and I also like to host static test environments that include the test runner.)

@slackersoft
Copy link
Member

@voltrevo I would definitely still be happy to take a look at a pull request that adds a checkbox to show the full spec tree even with filtered specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering out specs in HTML report
3 participants