Correctly pretty print objects from other contexts (e.g. iframes) and which do not override toString #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hang on, I've just found that foreign-context arrays are being misprinted for similar reasons, caused by the existing |
… which do not override toString Fixes #1087
|
Fixing the printing of foreign-context arrays was trivial. However, writing a test for that without creating another context and ensuring that it also works in IE8 seems to be impossible, as far as I'm aware. Is this PR sufficient as-is or do I need to do something more creative to test that part? |
|
Is there anything preventing this PR from being merged? |
|
Any news on this? We've had to create an internal fork with this PR and we'd rather not have it exist for too long. |
slackersoft
pushed a commit
that referenced
this pull request
Sep 27, 2016
…/thatfulvioguy/jasmine into thatfulvioguy-pretty-print-cross-frame-objects - Merges #1091 from @thatfulvioguy - Fixes #1087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087
The issue in question was caused by globals (including prototypes and functions on them) having different identities in different contexts (e.g. iframes and web workers), therefore making
value.toString !== Object.prototype.toStringwhere value is from another context. The approach taken here is to compare the result of the value's toString with Object.prototype.toString to see if they really are different. If they differ, then the value definitely has a custom toString.