Fix tests for toEqual diff output in IE
#1236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchristel
force-pushed
the
eq-diffs-ie-fix
branch
2 times, most recently
from
8586ed2
to
7b4163d
Compare
|
Hi @slackersoft, please review when you have a chance. It seems the IE tests are not actually being run on Travis for pending PRs, which would have caught this before the first PR was merged. Any reason the IE tests run for master but not for other branches? |
|
Unfortunately, none of the browser tests are run for pull requests. The way it's set up now we use SauceLabs for the browser tests, so we have our API info secured travis environment variables, which aren't available to pull request builds for security reasons. |
|
Ahh, that makes sense. Thanks for the info. |
- Mismatches were not being recorded on the diffBuilder when using the IE8 strategy for comparing DOM nodes. - IE8 doesn't support enumeration of the constructor property, so failure messages will not print the constructor property on IE8.
benchristel
force-pushed
the
eq-diffs-ie-fix
branch
from
7b4163d
to
c622c21
Compare
slackersoft
pushed a commit
that referenced
this pull request
Nov 30, 2016
- Merges #1236 from @benchristel
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes spec failures in IE caused by #1163