Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toThrowError with another global reports incorrectly #1252 #1275

Merged
merged 2 commits into from
Mar 10, 2017
Merged

toThrowError with another global reports incorrectly #1252 #1275

merged 2 commits into from
Mar 10, 2017

Conversation

anseki
Copy link
Contributor

@anseki anseki commented Feb 10, 2017

Check the thrown error and its constructor that should be Error.
The constructor might not be Error in current global, it might be child window or another window e.g. Electron.

@slackersoft
Copy link
Member

It looks like your specs are failing in phantomjs on Travis. Please take a look and get that to green.

Thanks for using Jasmine!

@anseki
Copy link
Contributor Author

anseki commented Feb 16, 2017

I guessed that you are using PhantomJS v1.9, right?
PhantomJS v1.9 has multiple bugs about iframe (https://github.com/ariya/phantomjs/issues?q=is%3Aissue+iframe+label%3ABug), and it can not get global by return this in iframe.
That was fixed in v2.0.

I think that v2.0+ should be used,
Anyway, I updated the spec, it skips the spec in PhantomJS v1.9-. Since this is a problem about only PhantomJS v1.9- not Jasmine, I think that it is OK to skip it.
I confirmed that it passed in both PhantomJS v1.9 and v2+.

@slackersoft slackersoft merged commit 19b89d4 into jasmine:master Mar 10, 2017
slackersoft pushed a commit that referenced this pull request Mar 10, 2017
Merge branch 'issue-1252' of https://github.com/anseki/jasmine into a…
e1f7ca5 
…nseki-issue-1252

- Merges #1275 from @anseki
- Fixes #1252
@slackersoft slackersoft mentioned this pull request Jun 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anseki @slackersoft