new Date() instanceof Date returns false if jasmine.clock() is installed

[chernetsov]

No description provided.

[slackersoft]

What version of jasmine are you using? I just ran this spec and it's green in the current code.

describe('with clock', function() {
  beforeEach(function() {
    jasmine.clock().install();
  });

  afterEach(function() {
    jasmine.clock().uninstall();
  });

  it('can date', function() {
    expect(new Date() instanceof Date).toBe(true);
  });
});

[chernetsov]

Here is the test that fails.

  describe('with clock', function() {
    beforeEach(function() {
      jasmine.clock().install();
      jasmine.clock().mockDate();
    });

    afterEach(function() {
      jasmine.clock().uninstall();
    });

    it('can date', function() {
      expect(new Date() instanceof Date).toBe(true);
    });
  });

I use Jasmine version 2.0.1.

[slackersoft]

Ahh, sorry, I didn't realize you were also mocking out Date. It looks like this is actually happening, not because the object being returned isn't a Date, but because the Date constructor has been rewritten to no longer be the original Date.

This looks like a bug we need to fix, so the state jasmine leaves Date in correctly passes an instanceof check. In the meantime, if you want to do something like:

expect(Object.prototype.toString.apply(new Date())).toEqual('[object Date]');

That should pass, and work in your code under test as well. I'll try to take a look at this at some point soon, but I'd definitely be glad to look at a pull request if you or anyone wants to give it a shot.

[chernetsov]

Check out my pull request with the fix.

Tried to follow all the contributor's cookbook rules.