Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skema and Tuple improvement #6

Open
antialize opened this issue Jul 18, 2014 · 0 comments
Open

Skema and Tuple improvement #6

antialize opened this issue Jul 18, 2014 · 0 comments
Assignees

Comments

@antialize
Copy link
Collaborator

I belive we would get better performance by alwayes keeping the keys of skemas sorted in lex order. The skema could be improved by not having a vector of name type pair but embedding it into the struct:

class NTP {
   Type type;
   std::string name;
};

class Tuple: public rm_object {
   uint32_t size;
   NTP coloums[0]; 
};

The tuple class could be improved by not using a vector of any values. Instead we could
make a tuple like

class Tuple: public rm_object {
     refptr<Skema> skema;
     int64_t items[0]
};

The type of an item can be extracted from the skema, so we should be able to do everything we do now, however it should be somewhat faster, but also somewhat more cumbersom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants