Add ProblemType.prototype.reject() method #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing http-status dependency - Fix test for ProblemType.prototype.throw() method - Add new test and documentation for ProblemType.prototype.reject() method
jasnell
approved these changes
Oct 11, 2016
|
Hi @jasnell , I see you have approved this PR, thank you. Could you please merge and release to NPM? As the project maintainer only you can perform the merge. Thank you |
- Support runtimes like Safari that do not support Error.captureStackTrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I really enjoy using your library. It is very straight forward and clean.
I created this PR with a couple minor fixes and a new prototype method to make it even easier to use with Promises. I have included some documentation and tests. Please take a look and let me know if you have any questions. Thanks!
Change details: