Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Authentication header with bearer token #41

Closed
jasny opened this issue Apr 21, 2016 · 3 comments
Closed

Use Authentication header with bearer token #41

jasny opened this issue Apr 21, 2016 · 3 comments

Comments

@jasny
Copy link
Owner

jasny commented Apr 21, 2016

Sending the SSO session token as query parameter can be unsafe. These typically appear in access and errors logs. This means ppl who have access to these logs (developers, devops, etc) can abuse these tokens.

Instead we should send an Authentication Bearer header with the session token. See RFC 6750.

For BC the SSO server should accept both.

@infabo
Copy link

infabo commented Apr 22, 2016

+1

@jasny
Copy link
Owner Author

jasny commented Sep 23, 2016

The server should accept the value through an Authentication: Bearer ... header as well as the access_token query ($_GET) or form ($_POST) parameter.

It should also still accept the session_id query parameter for backwards compatibility.

@jasny
Copy link
Owner Author

jasny commented Oct 10, 2016

Fixed in #53

@jasny jasny closed this as completed Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants