Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change --model parameter from phoenix to aces. #128

Closed
jason-neal opened this issue Feb 6, 2019 · 1 comment
Closed

Change --model parameter from phoenix to aces. #128

jason-neal opened this issue Feb 6, 2019 · 1 comment

Comments

@jason-neal
Copy link
Owner

Change the --model input flag name.

Depreciate the --model phoenix option from phoneix_precisions.py and make it aces to easily distinguish between aces and btsettl.

Keep phoenix as a valid option (but remove from docs/help) but include depreciation warning.
jason-neal added a commit that referenced this issue Feb 20, 2019
@jason-neal
Depreciate the model name ´phoenix´.
7066210 
Added a model check with tests.

PR #128
@jason-neal
Copy link
Owner Author

jason-neal commented Feb 20, 2019 •
edited
Loading

Still need to check this in the documentation.

@jason-neal jason-neal mentioned this issue Feb 20, 2019
Merged
jason-neal added a commit that referenced this issue Feb 21, 2019
@jason-neal
Change --model flag options (#130)
0991d4d 
* Depreciate the model name ´phoenix´.

Added a model check with tests.

PR #128

* Use pytest.deprecated_call

* Update changelog
jason-neal added a commit that referenced this issue Apr 7, 2019
@jason-neal
Change --model flag options (#130)
e7f044f 
* Depreciate the model name ´phoenix´.

Added a model check with tests.

PR #128

* Use pytest.deprecated_call

* Update changelog


Former-commit-id: e97aae23b1becac60aacdef8f55c4a7c0e0dabb5 [formerly 87693f4ff7a73db18dbe23a95d3bd9be4e67f941]
Former-commit-id: 4d9e19f514b4960dad27cd07ad32dadf5dae5309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jason-neal