Update phoenix-aces data download. #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create new download script using new Starfish functions. Cache data on CI services
# Conflicts: # MANIFEST.in
# Conflicts: # CHANGELOG.md # requirements_dev.txt # setup.py # tests/download_test_PHOENIX_spec.sh
Repository owner
deleted a comment
Mar 12, 2019
Repository owner
deleted a comment
Mar 12, 2019
Repository owner
deleted a comment
Mar 13, 2019
Repository owner
deleted a comment
Mar 13, 2019
Repository owner
deleted a comment
Mar 13, 2019
Repository owner
deleted a comment
Mar 13, 2019
Repository owner
deleted a comment
Mar 13, 2019
Repository owner
deleted a comment
Mar 13, 2019
jason-neal
added a commit
that referenced
this pull request
Apr 7, 2019
* Use http for phoenix data * Move download scripts to scripts/download. Create new download script using new Starfish functions. Cache data on CI services * Fix starfish #egg * Fix download_test_aces.py Starfish downloaded takes a iterable of iterables. * Fix appveyor escape characters in paths \\. * fix ps_download_eniric_data.ps1 Add Python/Scripts path to appveryor config. Former-commit-id: 5d57495b073cfd4296c6aeff9005ba06f3244556 [formerly c342965d6de0c6a646199e615452f6a886817878] Former-commit-id: 81c66a359e70623314f13ae6b78ab8ad5b5a6de0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Starfish's downloading function for phoenix-aces spectra, involves caching.
Move download scripts to scripts/download.
Starfish-develop/Starfish#108