-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove installation of SampleFeatureToggle into the projects when installing via NuGet #117
Comments
Thanks @samholder - I agree - I will remove this for next release and consider the additional packages for future releases. |
Added #119 to capture idea for additional nugets |
This would be great, I am currently removing the sample feature toggle from about 20 projects because FeatureToggle is a transitive dependency so it got added everywhere :) |
Just doing this now. @JakeGinnivan do you think as far as semver is concerned you'd consider this a breaking change? |
Nope, it only happens during installation so it won't affect anyone existing. |
@JakeGinnivan yeah, that's kinda what I was thinking - thanks |
Thanks! much appreciated! |
@samholder no worries |
Whilst having a SampleFeatureToggle is a reasonable idea for people starting out, having this added to every project, every time you install/update the nuget package becomes annoying very quickly.
A model some other projects (essential diagnostics being one) follow is to have 2 nuget packages. One which just install the core libraries (FeatureToggle) and one which installs the samples and config examples (FeatureToggle.Config or FeatureToggle.Samples maybe). This allows the users the choice of whether they want to have the samples or not.
The text was updated successfully, but these errors were encountered: