Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove installation of SampleFeatureToggle into the projects when installing via NuGet #117

Closed
samholder opened this issue May 20, 2016 · 8 comments

Comments

@samholder
Copy link

Whilst having a SampleFeatureToggle is a reasonable idea for people starting out, having this added to every project, every time you install/update the nuget package becomes annoying very quickly.

A model some other projects (essential diagnostics being one) follow is to have 2 nuget packages. One which just install the core libraries (FeatureToggle) and one which installs the samples and config examples (FeatureToggle.Config or FeatureToggle.Samples maybe). This allows the users the choice of whether they want to have the samples or not.

@jason-roberts
Copy link
Owner

Thanks @samholder - I agree - I will remove this for next release and consider the additional packages for future releases.

@jason-roberts jason-roberts changed the title Allow the option not to install SampleFeatureToggle into the projects Removie installation of SampleFeatureToggle into the projects when installing via NuGet May 23, 2016
@jason-roberts jason-roberts changed the title Removie installation of SampleFeatureToggle into the projects when installing via NuGet Remove installation of SampleFeatureToggle into the projects when installing via NuGet May 23, 2016
@jason-roberts
Copy link
Owner

Added #119 to capture idea for additional nugets

@JakeGinnivan
Copy link

This would be great, I am currently removing the sample feature toggle from about 20 projects because FeatureToggle is a transitive dependency so it got added everywhere :)

@jason-roberts
Copy link
Owner

Just doing this now. @JakeGinnivan do you think as far as semver is concerned you'd consider this a breaking change?

@JakeGinnivan
Copy link

Nope, it only happens during installation so it won't affect anyone existing.

@jason-roberts
Copy link
Owner

@JakeGinnivan yeah, that's kinda what I was thinking - thanks

@samholder
Copy link
Author

Thanks! much appreciated!

@jason-roberts
Copy link
Owner

@samholder no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants